Smoking, metabolic syndrome (MetS), and major adverse cardiovascular events (MACEs) are important global health problems. We aimed to investigate the association between smoking, alteration in MetS status, and the consequent risk of MACE. We performed a nationwide observational cohort study based on the claims database of Korea. We included people with ≥ 3 national health screenings from 2009 to 2013. Total 6,099,717 people, including 3,576,236 nonsmokers, 862,210 ex-smokers, 949,586 light-to-moderate smokers, and 711,685 heavy smokers, at the first health screening, were investigated. First, we performed a logistic regression analysis using smoking status at the first screening as the exposure variable and MetS development or recovery as the outcome variable. Second, we performed a Poisson regression using smoking status at the third screening as the exposure variable and the outcome was risk of incident MACEs. Among those previously free from MetS (N = 4,889,493), 347,678 people developed MetS, and among those who had previous MetS (N = 1,210,224), 347,627 people recovered from MetS. Smoking was related to a higher risk of MetS development [for heavy smokers: adjusted OR 1.71 (1.69 to 1.73)] and a lower probability of MetS recovery [for heavy smokers: adjusted OR 0.68 (0.67 to 0.69)]. Elevated triglycerides was the MetS component with the most prominent association with smoking. The risk for incident MACEs (78,640 events during a median follow-up of 4.28 years) was the highest for heavy smokers, followed in order by light-to-moderate, ex-smokers and nonsmokers, for every MetS status. Therefore, smoking may promote MetS or even hinder recovery from MetS. Smoking cessation should be emphasized to reduce MACE risk even for those without MetS.